Skip to content

Feat/#151: Many-to-Many Support via [HasManyThrough] #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 3, 2018
Merged

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Oct 3, 2018

Closes #151

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements

NOTES

[Q] When PATCH-ing a HasManyThrough relationship, what happens if the through type has other properties besides the navigation properties?
[A] This operation acts as a PUT operation. It will remove any old join entities and create new ones. So, any attributes on the join entity will be set to default(T). This is because we don't have a good way to communicate the concept of updating a specific member of a HasMany set. If you need to update the join entity attributes, that should be done using normal json:api resources. I would also recommend considering json:api v1.1 operations for this use case.

@jaredcnance jaredcnance merged commit 5049281 into master Oct 3, 2018
@jaredcnance jaredcnance deleted the feat/#151 branch October 3, 2018 04:52
@jaredcnance jaredcnance mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant